Skip to content

Comments

Remove obsolete jq filter test after feature removal#14893

Merged
pelikhan merged 2 commits intocopilot/remove-jq-arguments-supportfrom
copilot/fix-test-issue
Feb 11, 2026
Merged

Remove obsolete jq filter test after feature removal#14893
pelikhan merged 2 commits intocopilot/remove-jq-arguments-supportfrom
copilot/fix-test-issue

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

PR #14887 removed jq filter support from MCP server tools. The status_invalid_jq_filter test case remained, expecting validation errors for malformed jq expressions. Since the jq parameter is now rejected at the schema level as an unexpected property, the test fails.

Changes

  • Removed test case: TestMCPServer_ErrorCodes_InvalidParams/status_invalid_jq_filter from pkg/cli/mcp_server_error_codes_test.go
  • Cleaned imports: Removed unused testutil package import

The test was validating error messages for invalid jq syntax:

params := &mcp.CallToolParams{
    Name: "status",
    Arguments: map[string]any{
        "jq": ".invalid[syntax",  // No longer accepted
    },
}

Now the parameter itself is rejected before reaching any jq-specific validation logic.

Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/21894085314/job/63206261538#step:10:1

Fix test


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix test to ensure correct functionality Remove obsolete jq filter test after feature removal Feb 11, 2026
Copilot AI requested a review from pelikhan February 11, 2026 05:53
@pelikhan pelikhan marked this pull request as ready for review February 11, 2026 05:55
Copilot AI review requested due to automatic review settings February 11, 2026 05:55
@pelikhan pelikhan merged commit 8de2ef9 into copilot/remove-jq-arguments-support Feb 11, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/fix-test-issue branch February 11, 2026 05:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an obsolete MCP server integration test that still exercised the deprecated jq argument, which is now rejected at the schema/parameter-validation layer after PR #14887 removed jq support.

Changes:

  • Removed the status_invalid_jq_filter subtest from TestMCPServer_ErrorCodes_InvalidParams.
  • Cleaned up imports by dropping the now-unused pkg/testutil import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants